Datasets:
owner stringclasses 1
value | repo stringclasses 1
value | id int64 18.6M 4.15B | issue_number int32 1 36.2k | author stringlengths 0 39 | body stringlengths 0 201k | created_at timestamp[us]date 2013-05-29 20:32:19 2026-03-28 19:52:14 | updated_at timestamp[us]date 2013-05-29 20:32:19 2026-03-28 19:52:14 | reactions unknown | author_association stringclasses 6
values |
|---|---|---|---|---|---|---|---|---|---|
facebook | react | 18,991,998 | 64 | zpao | Fixed with a64faf7bf7edeab22490c617d1c579e6103a5da0 and re-rolled the site, should be up in a few minutes. Thanks for the heads up!
| 2013-06-05T17:04:24 | 2013-06-05T17:04:24 | {} | MEMBER |
facebook | react | 20,264,342 | 70 | sophiebits | (This was already committed in c9ecbaccb365ba39bd8839f61ae245cdc295317b and should be in 0.4 when it comes out.)
| 2013-07-01T05:45:44 | 2013-07-01T05:45:44 | {} | COLLABORATOR |
facebook | react | 20,264,263 | 70 | ericclemmons | +1 This would be extremely useful. There are several instances where you explicitly call a helper function, but have to litter your template with `.bind(this)` references for everything to work correctly.
I can't think of when a function would be expected to run _outside_ of the component's scope...
| 2013-07-01T05:42:19 | 2013-07-01T05:42:19 | {} | CONTRIBUTOR |
facebook | react | 20,264,507 | 70 | petehunt | Should have closed this :) thanks!
| 2013-07-01T05:53:36 | 2013-07-01T05:53:36 | {} | CONTRIBUTOR |
facebook | react | 20,212,708 | 131 | petehunt | @benjamn and I came up with a game plan on IRC; we'll be opening more specific actionable issues moving forward.
| 2013-06-28T20:34:01 | 2013-06-28T20:34:01 | {} | CONTRIBUTOR |
facebook | react | 19,589,375 | 82 | jeffmo | Just an update: I've got a change to the parser queued up that allows for `<div>{/* this is a comment*/}</div>`.
I'll probably send it out tomorrow after I've had some time to do a little more extensive testing first...but it should do the trick
| 2013-06-18T03:47:50 | 2013-06-18T03:47:50 | {} | CONTRIBUTOR |
facebook | react | 19,290,609 | 82 | vjeux | Things we also talked about:
- Adding `<!-- comment -->` that would be transformed into `/* comment */`
- We can already do the following but they are not optimal: `{{/* comment */}}`, `{[/* comment */]}`, `{!/* comment /*0}`
- Handlebar does the following: `{{! comment }}`
- Javascript comments are already working within the tag: `<div /* comment */>` and `<div // comment \n>`
| 2013-06-11T20:39:19 | 2013-06-11T20:39:19 | {} | CONTRIBUTOR |
facebook | react | 19,176,162 | 76 | zpao | I can see why that would cause issues… The way you're thinking about sounds like common sense so I hope that's actually true and that we're just firing these callbacks in the wrong order. So _I_ agree, but that's without looking at the code closely
| 2013-06-09T23:32:03 | 2013-06-09T23:32:03 | {} | MEMBER |
facebook | react | 19,180,773 | 76 | jordwalke | I think this makes sense. Here's my reasoning: One of the few valid reasons for wanting to use `componentDidMount(node)` (besides integrating with other frameworks) is to measure something's container. In order to do that accurately, the children might also want to have measured their own containers. For the parent's measurement to be accurate, the child's `componentDidMount` must have already completed.
| 2013-06-10T04:50:54 | 2013-06-10T04:50:54 | {} | CONTRIBUTOR |
facebook | react | 19,262,409 | 79 | benjamn | I wasn't able to reproduce this on my machine, but I suspect something is going wrong in `test/phantom-harness.js`. If you have some time, can you try sprinkling some `console.log` statements in there, just to see how far it gets before it hangs?
| 2013-06-11T13:46:07 | 2013-06-11T13:46:07 | {} | CONTRIBUTOR |
facebook | react | 19,274,176 | 79 | jordwalke | It gets to phantom:run:
| 2013-06-11T16:42:58 | 2013-06-11T16:42:58 | {} | CONTRIBUTOR |
facebook | react | 19,249,035 | 79 | jordwalke | If I try grunt test -debug, and click the link, they all pass. But the command line gives no output.
| 2013-06-11T08:39:16 | 2013-06-11T08:39:16 | {} | CONTRIBUTOR |
facebook | react | 20,264,754 | 79 | petehunt | Fixed now
| 2013-07-01T06:05:50 | 2013-07-01T06:05:50 | {} | CONTRIBUTOR |
facebook | react | 19,256,125 | 79 | benjamn | Does it hang on phantom:run, or does it not get that far?
| 2013-06-11T11:35:40 | 2013-06-11T11:35:40 | {} | CONTRIBUTOR |
facebook | react | 19,483,189 | 79 | benjamn | @jordow any luck with this? Still can't reproduce it here, but happy to dig deeper if it's still a problem.
| 2013-06-14T21:40:27 | 2013-06-14T21:40:27 | {} | CONTRIBUTOR |
facebook | react | 20,285,677 | 138 | benjamn | Looking into this. First clue: `grunt jsx:test` seems to be compiling more files in Travis than it does locally.
| 2013-07-01T14:35:50 | 2013-07-01T14:35:50 | {} | CONTRIBUTOR |
facebook | react | 20,288,167 | 138 | benjamn | Opened a Commoner issue that should address this, among other problems: https://github.com/benjamn/commoner/issues/30
| 2013-07-01T15:13:32 | 2013-07-01T15:13:32 | {} | CONTRIBUTOR |
facebook | react | 19,555,951 | 100 | zpao | I think this got fixed by 100af48f53e292898562f76e0edc9fc7ce50b04e, but haven't confirmed
| 2013-06-17T16:16:11 | 2013-06-17T16:16:11 | {} | MEMBER |
facebook | react | 19,556,135 | 100 | zpao | And confirmed that it's working in master.
| 2013-06-17T16:18:52 | 2013-06-17T16:18:52 | {} | MEMBER |
facebook | react | 19,827,560 | 118 | sophiebits | This is standard behavior for JavaScript (unrelated to React), and is expected.

Floating-point numbers such as 0.1 and 0.2 can't be represented exactly in binary, so an approximation is used. It's as if you (in base 10) added 0.333 + 0.333 + 0.333 and got 0.999 instead of 1 -- just an artifact of the rounding that happens. Here's a Stack Overflow question explaining this phenomenon: http://stackoverflow.com/q/588004/49485
| 2013-06-21T16:54:34 | 2013-06-21T16:54:34 | {} | COLLABORATOR |
facebook | react | 19,924,654 | 118 | zpao | @ldhieu Yea, this is expected behavior with JS. One common solution when working with decimals (eg, currency) is to just use whole numbers, then divide by some number when you need to display the number to a use. $1.01 would be stored as 101 and then when displaying that to the user you would do `num / 100`.
| 2013-06-24T18:07:58 | 2013-06-24T18:07:58 | {} | MEMBER |
facebook | react | 20,082,125 | 125 | benjamn | This is in! https://github.com/facebook/react/commit/67cf44e7c18e068e3f39462b7ac7149eee58d3e5
| 2013-06-26T21:38:24 | 2013-06-26T21:38:24 | {} | CONTRIBUTOR |
facebook | react | 20,024,323 | 125 | hojberg | +1
| 2013-06-26T02:50:27 | 2013-06-26T02:50:27 | {} | CONTRIBUTOR |
facebook | react | 20,023,941 | 125 | benjamn | You're right!
I've been working on this problem recently, and I'm very close to a solution that will allow `ATTR_NAME` to be changed at will in this file: https://github.com/facebook/react/blob/a9b024330c/src/core/ReactID.js#L24
My plan was to use `data-reactid`, which is almost identical to your suggestion.
| 2013-06-26T02:35:34 | 2013-06-26T02:35:34 | {} | CONTRIBUTOR |
facebook | react | 20,494,399 | 159 | jordwalke | I was just running into this same issue. One of the react-tools npm pushes did not have the build. I believe @zpao fixed this now in npm. Someone should update reactify to depend on the latest version of react-tools and I believe it should be fixed. Can you confirm?
| 2013-07-04T21:45:16 | 2013-07-04T21:45:16 | {} | CONTRIBUTOR |
facebook | react | 20,494,951 | 159 | pconerly | Oh, that's a really good point.
If you want an immediate and hacky fix you can just change `/node_modules/reactify/node_modules/react-tools/main.js` to be:
``` js
'use strict';
//var React = require('./build/modules/React');
var visitors = require('./vendor/fbtransform/visitors').transformVisitors;
var transform = require('./vendor/fbtransform/lib/transform').transform;
module.exports = {
//React: React,
transform: function(code) {
return transform(visitors.react, code).code;
}
};
```
and viola.
| 2013-07-04T22:11:41 | 2013-07-04T22:11:41 | {} | NONE |
facebook | react | 20,494,591 | 159 | pconerly | Cool, I did a
```
rm -rf node_modules/
npm install
```
And I'm installing `react-tools` both directly and via reactify.
It's still not there. Reactify requires `~0.3.1` which was going to `0.3.3` anyway with tilde rules.
Maybe a dumb question-- do I need to clear a npm cache or something?
Thanks for the quick response! Might as well code while waiting for fireworks...
| 2013-07-04T21:54:15 | 2013-07-04T21:54:15 | {} | NONE |
facebook | react | 20,494,781 | 159 | jordwalke | Interestingly, reactify shouldn't even rely on the build output - it should only need the bin folder to do the transformation. We should have another npm module just for "react.js which is what it's getting out of the build directory.
| 2013-07-04T22:03:07 | 2013-07-04T22:03:07 | {} | CONTRIBUTOR |
facebook | react | 20,533,398 | 159 | pconerly | @zpao cool, I didn't know about `npm cache clean`, confirmed as fixed.
| 2013-07-05T18:43:38 | 2013-07-05T18:43:38 | {} | NONE |
facebook | react | 20,494,772 | 159 | jordwalke | I'm still seeing the same issue that you are. I'd like to get this fixed because I too want to try out reactify as well.
| 2013-07-04T22:02:23 | 2013-07-04T22:02:23 | {} | CONTRIBUTOR |
facebook | react | 20,532,405 | 159 | zpao | @jordwalke @pconerly - `npm cache clean` will also make this work again. (testing without clearing cache worked on my machine because I published it, so it must have cleared the cache in the process). I should probably bump to 0.3.4 :/
| 2013-07-05T18:19:47 | 2013-07-05T18:19:47 | {} | MEMBER |
facebook | react | 20,495,992 | 159 | petehunt | Here's what I did for grunt-react; could work for reactify too https://github.com/ericclemmons/grunt-react/pull/2/files. Maybe I will find time for a pull one of these days on reactify :)
Sent from my iPhone
On Jul 4, 2013, at 3:11 PM, "Peter Conerly" <notifications@github.com<mailto:notifications@github.com>> wrote:
Oh, that's a really good point.
If you want an immediate and hacky fix you can just change /node_modules/reactify/node_modules/react-tools/main.js to be:
'use strict';
//var React = require('./build/modules/React');
var visitors = require('./vendor/fbtransform/visitors').transformVisitors;
var transform = require('./vendor/fbtransform/lib/transform').transform;
module.exports = {
//React: React,
transform: function(code) {
return transform(visitors.react, code).code;
}
};
and viola.
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v1/url?u=https://github.com/facebook/react/issues/159%23issuecomment-20494951&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=qYx6qLphxKhA5vHBqr9vuw%3D%3D%0A&m=kUsZcVcl76jdJjXpzGIx4DI8H8kvdq3L9MIShHM2wLI%3D%0A&s=a18f23f7dc9205c9ca0c24cd45ff1df3493a2b0b0afa657b3fdca9e5bd3e3f7d.
| 2013-07-04T23:13:08 | 2013-07-04T23:13:08 | {} | CONTRIBUTOR |
facebook | react | 20,215,044 | 137 | benjamn | Recommended workaround for the time being: just run `grunt test` again; due to caching, it will pick up where it left off.
| 2013-06-28T21:19:29 | 2013-06-28T21:19:29 | {} | CONTRIBUTOR |
facebook | react | 20,215,090 | 137 | benjamn | Confirming that reducing `MAX_READ_COUNT` for Commoner's file reading queue makes the problem go away:
https://github.com/benjamn/commoner/blob/f006bac9c9152e6ffcb33eb8cc3a6f994f57a794/lib/util.js#L56
| 2013-06-28T21:20:32 | 2013-06-28T21:20:32 | {} | CONTRIBUTOR |
facebook | react | 20,314,428 | 111 | benjamn | What if the tie was broken according to the length of the filename (shortest wins)? Is that too much of a hack?
| 2013-07-01T22:13:49 | 2013-07-01T22:13:49 | {} | CONTRIBUTOR |
facebook | react | 20,070,812 | 111 | zpao | @benjamn Should we fix this in commoner?
| 2013-06-26T18:46:52 | 2013-06-26T18:46:52 | {} | MEMBER |
facebook | react | 20,354,359 | 111 | benjamn | Fixed in Commoner 0.8.1: https://github.com/benjamn/commoner/issues/31
| 2013-07-02T15:45:43 | 2013-07-02T15:45:43 | {} | CONTRIBUTOR |
facebook | react | 20,314,349 | 111 | benjamn | Oh, interesting. I dealt with a related problem with Emacs `~` files a while back:
https://github.com/benjamn/commoner/commit/4ed07b31a6ccafe3423f0f52194c12662df16cd2
Definitely a thing that Commoner should handle intelligently.
| 2013-07-01T22:12:11 | 2013-07-01T22:12:11 | {} | CONTRIBUTOR |
facebook | react | 20,351,980 | 111 | benjamn | @zpao good call; turns out CoffeeScript doesn't try to be super clever about this: https://github.com/jashkenas/coffee-script/blob/8e90aaefc1/lib/coffee-script/command.js#L33-L35
| 2013-07-02T15:12:36 | 2013-07-02T15:12:36 | {} | CONTRIBUTOR |
facebook | react | 20,314,555 | 111 | zpao | What do other things (like `coffee`) do? This can't be a new problem...
| 2013-07-01T22:16:09 | 2013-07-01T22:16:09 | {} | MEMBER |
facebook | react | 19,493,024 | 94 | jordwalke | Great intuition. Several of us have thought about this opportunity and are thinking about approaches very similar to what you suggest. One of the benefits of defining style rules and css class specifications in JavaScript, is that you can use the full power of JavaScript to define styles, which we already have ways to model dependencies for. We wouldn't need another language like SASS or Less. Also, as you mention, since we also own the rendering/abstraction framework, we can ensure that we don't polute the CSS namespace. We can also ensure that components don't target nodes/class names that should be considered an implementation detail (concern) of a deeper component.
| 2013-06-15T08:11:20 | 2013-06-15T08:11:20 | {} | CONTRIBUTOR |
facebook | react | 21,313,325 | 94 | vjeux | You can do the following right now:
```
getStyle: function() {
return {
fruit: {border: '1px solid black'}
}
},
render: function() {
return <div style={this.getStyle()}>Hello</div>;
}
```
Let's close this out until someone comes with a real proposal :)
| 2013-07-21T17:13:59 | 2013-07-21T17:13:59 | {} | CONTRIBUTOR |
facebook | react | 19,277,548 | 80 | benjamn | Commoner task: https://github.com/benjamn/commoner/issues/28
| 2013-06-11T17:23:51 | 2013-06-11T17:23:51 | {} | CONTRIBUTOR |
facebook | react | 19,284,408 | 80 | zpao | :+1:
| 2013-06-11T18:56:37 | 2013-06-11T18:56:37 | {} | MEMBER |
facebook | react | 21,271,176 | 215 | sophiebits | I'm not sure I understand. The code in master says:
```
var nextProps = this.props;
if (this._pendingProps != null) {
nextProps = this._pendingProps;
...
var nextState = this._pendingState || this.state;
```
After nextProps is set to this._pendingProps, it's mutated only by _performComponentUpdate (if shouldComponentUpdate returns true) or directly in the _performUpdateIfNecessary function (if shouldComponentUpdate returns false).
| 2013-07-19T19:16:59 | 2013-07-19T19:16:59 | {} | COLLABORATOR |
facebook | react | 21,282,663 | 215 | zpao | Ok, this isn't related to batching at all. It's actually the age-old objects are passed byref problem.
In the case we were hitting, we have an object storing data coming from the server. Sometimes the server will say "update the number we have stored for this object", so we set object.test++, then re-render with object as a prop.
Here's a test case demonstrating the problem:
```
it('should pass shouldUpdate the correct values', function() {
var _propsWereDifferent = [];
var count = 0;
var data = { test: 1 };
var Component = React.createClass({
shouldComponentUpdate: function(nextProps, nextState) {
_propsWereDifferent[count++] =
nextProps.data.test !== this.props.data.test;
},
render: function() {
return <div/>;
}
});
var instance = <Component data={data} />;
ReactTestUtils.renderIntoDocument(instance);
data.test++;
instance.setProps({ data: data });
instance.setProps({ data: data });
data.test++;
instance.setProps({ data: data });
expect(_propsWereDifferent.length).toBe(3); // pass
expect(_propsWereDifferent[0]).toBe(true); // pass
expect(_propsWereDifferent[1]).toBe(false); // fail
expect(_propsWereDifferent[2]).toBe(true); // fail
});
```
The best way to work around this is probably to pull as much off of `data` and set each property as props on your component instead.
| 2013-07-19T23:06:06 | 2013-07-19T23:06:06 | {} | MEMBER |
facebook | react | 21,283,578 | 215 | zpao | FWIW, this isn't a bug in React - this is something to be aware of in all JS. JSX makes this a little less obvious.
| 2013-07-19T23:35:43 | 2013-07-19T23:35:43 | {} | MEMBER |
facebook | react | 21,274,103 | 215 | hrach | I have experienced this too :) So keep digging :-) :+1:
| 2013-07-19T20:07:07 | 2013-07-19T20:07:07 | {} | NONE |
facebook | react | 21,273,951 | 215 | zpao | May have jumped the gun on this... trying to get a reduced test case that fails (so far I can only make passing test cases).
| 2013-07-19T20:04:46 | 2013-07-19T20:04:46 | {} | MEMBER |
facebook | react | 18,952,872 | 60 | benjamn | Installed 0.8.23 but no luck reproducing. Will try on a Mountain Lion machine tomorrow. Thanks for the report.
Do you see this failure with an empty `.js` file? If using an empty file makes the failure go away, perhaps you can try cutting out different parts of the file to figure out the minimal contents that trigger the failure?
It could be a problem with `fs.watch` on Mountain Lion, though. That's my hunch.
| 2013-06-05T02:57:18 | 2013-06-05T02:57:18 | {} | CONTRIBUTOR |
facebook | react | 19,438,845 | 60 | hieu | I had same problem on ubuntu. Yesterday "jsx --watch" worked just fine for me. Today when I ssh-ed again and ran "jsx --watch reactjs/ js/" it just silently does nothing.
| 2013-06-14T04:32:52 | 2013-06-14T04:32:52 | {} | NONE |
facebook | react | 18,954,068 | 60 | hojberg | The same file builds fine if I use `jsx -w src/ public` (note the lack of public/js).
Deleting that directory didn't work for me.
| 2013-06-05T03:49:03 | 2013-06-05T03:49:03 | {} | CONTRIBUTOR |
facebook | react | 19,440,161 | 60 | jeffreylin | @hojberg @hieu - I was having issues w/ vim file writes not being caught so I hacked together https://github.com/jeffreylin/jsx_transformer_fun - Feel free to try it and let me know if it works (Haven't had the time to test on Ubuntu yet...) - We might use the file watcher in that repo in Commoner / JSX in the future.
| 2013-06-14T05:39:05 | 2013-06-14T05:39:05 | {} | CONTRIBUTOR |
facebook | react | 19,305,223 | 60 | hojberg | :heart:
| 2013-06-12T03:27:35 | 2013-06-12T03:27:35 | {} | CONTRIBUTOR |
facebook | react | 19,293,931 | 60 | benjamn | I know this is still broken. Still working on a fix.
| 2013-06-11T21:34:22 | 2013-06-11T21:34:22 | {} | CONTRIBUTOR |
facebook | react | 18,950,133 | 60 | benjamn | Are there any `.js` files in `src/` yet?
Also potentially useful: what `node --version` are you running, and what OS?
| 2013-06-05T01:22:03 | 2013-06-05T01:22:03 | {} | CONTRIBUTOR |
facebook | react | 19,443,044 | 60 | hieu | @jeffreylin :+1: Work like a charm. Thank you very much!
| 2013-06-14T07:27:35 | 2013-06-14T07:27:35 | {} | NONE |
facebook | react | 19,523,187 | 60 | hojberg | Ok. I think I now know what the issue is.
jsx created a .lock.pid file in the output directory. If that file is still there when running jsx again it will quick silently.
| 2013-06-17T01:48:02 | 2013-06-17T01:48:02 | {} | CONTRIBUTOR |
facebook | react | 18,951,757 | 60 | hojberg | There is a file in src which builds when not using a subdir in the public dir.
node version is 0.8.23 and im on OS X Mountain Lion
| 2013-06-05T02:19:17 | 2013-06-05T02:19:17 | {} | CONTRIBUTOR |
facebook | react | 18,953,174 | 60 | benjamn | One more idea: the module cache might have gotten into a bad state somehow. Try clearing it by deleting the directory `~/.commoner/module-cache`?
| 2013-06-05T03:10:47 | 2013-06-05T03:10:47 | {} | CONTRIBUTOR |
facebook | react | 20,759,402 | 182 | jordwalke | Could you give a simple use case where it does not render numbers? There's an interesting reason why you may not want booleans to be rendered as strings.
```
children = something && <div />
```
| 2013-07-10T17:38:44 | 2013-07-10T17:38:44 | {} | CONTRIBUTOR |
facebook | react | 20,767,746 | 182 | steida | Sorry, I was my fault. Add booleans, I didn't know that, thank you.
| 2013-07-10T19:44:22 | 2013-07-10T19:44:22 | {} | NONE |
facebook | react | 21,272,605 | 165 | zpao | 894bb03b230336490d20e38cf1f44e9d4d4b78cc
| 2013-07-19T19:41:31 | 2013-07-19T19:41:31 | {} | MEMBER |
facebook | react | 20,419,661 | 154 | benjamn | I have ideas.
If we take the plunge of forking browserify, then a lot of things become possible. A proper mocking system would be relatively easy to implement if we could redefine browserify's implementation of `require`.
But I don't think we have to fork browserify. Instead, it looks like we can transform our own source files during testing so that `require("mock-modules")` can manipulate their `module.exports`, swapping a mocked version of `exports` in and out as necessary. We can do this either in `bin/jsx` or using a browserify source transform. I prefer `bin/jsx` because then, in principle at least, mocking would work with any module packaging tool (i.e. it would not depend on the browserify interface).
Need to investigate further, but I think this is really promising.
| 2013-07-03T14:40:20 | 2013-07-03T14:40:20 | {} | CONTRIBUTOR |
facebook | react | 20,396,456 | 154 | petehunt | OK, the tests passed internally but not in open-source because dumpCache() is a no-op, so double DOM property injection is happening and throwing.
| 2013-07-03T05:30:06 | 2013-07-03T05:30:06 | {} | CONTRIBUTOR |
facebook | react | 20,988,297 | 191 | zpao | This has been fixed in the upcoming v0.4 thanks to our improved synthetic events. Thanks for reporting and providing a test case!
| 2013-07-15T17:47:06 | 2013-07-15T17:47:06 | {} | MEMBER |
facebook | react | 20,988,436 | 191 | hrach | Awesome. Thanks! :)
| 2013-07-15T17:48:55 | 2013-07-15T17:48:55 | {} | NONE |
facebook | react | 18,864,057 | 50 | subtleGradient | The XJS project hasn't gotten any code since it was created in 2011 http://code.google.com/p/xjs/source/list
| 2013-06-03T19:15:55 | 2013-06-03T19:15:55 | {} | CONTRIBUTOR |
facebook | react | 21,313,291 | 50 | vjeux | We're 2 months into the release, let's close it out :)
| 2013-07-21T17:11:24 | 2013-07-21T17:11:24 | {} | CONTRIBUTOR |
facebook | react | 19,699,360 | 24 | zpao | I changed this to only rewrite the file on version bumps in de2832c0c0ec1b54f06334ae25a0bf8fc947dc9e, so I'm going to call it good enough and close this out.
| 2013-06-19T17:24:34 | 2013-06-19T17:24:34 | {} | MEMBER |
facebook | react | 21,313,243 | 16 | vjeux | See #114 :)
| 2013-07-21T17:08:03 | 2013-07-21T17:08:03 | {} | CONTRIBUTOR |
facebook | react | 21,313,401 | 127 | vjeux | It's now in the doc :) http://facebook.github.io/react/docs/reusable-components.html
| 2013-07-21T17:19:13 | 2013-07-21T17:19:13 | {} | CONTRIBUTOR |
facebook | react | 20,264,100 | 127 | ericclemmons | Granted, this is a placeholder for a todo you already have in mind, but what exactly are you looking for regarding documentation?
| 2013-07-01T05:34:14 | 2013-07-01T05:34:14 | {} | CONTRIBUTOR |
facebook | react | 20,265,227 | 127 | vjeux | Adding a page saying that you can write the following code
```
React.createClass({
props: {
someNumber: React.Props.
}
})
--
Christopher "vjeux" Chedeau
Facebook Engineer
http://blog.vjeux.com/
On Jun 30, 2013, at 10:34 PM, Eric Clemmons <notifications@github.com> wrote:
> Granted, this is a placeholder for a todo you already have in mind, but what exactly are you looking for regarding documentation?
>
> —
> Reply to this email directly or view it on GitHub.
```
| 2013-07-01T06:27:14 | 2013-07-01T06:27:14 | {} | CONTRIBUTOR |
facebook | react | 19,411,177 | 37 | mateusmaso | just wondering how reconciliation really works.. like what conditions are made to merge the dom efficiently and what is the logic behind the .reactRoot[n] tracking... I think this is the part where React.js really shines for me and I even would use it as part of a separate library for people who just want that functionality.
| 2013-06-13T17:58:13 | 2013-06-13T17:58:13 | {} | NONE |
facebook | react | 21,313,212 | 37 | vjeux | New docs mention it :)
| 2013-07-21T17:05:49 | 2013-07-21T17:05:49 | {} | CONTRIBUTOR |
facebook | react | 19,303,423 | 37 | vjeux | @jordow: Ping!
| 2013-06-12T02:14:32 | 2013-06-12T02:14:32 | {} | CONTRIBUTOR |
facebook | react | 19,483,888 | 37 | jordwalke | You can find out a little bit more from Lee's post here:
http://www.quora.com/React-JS-Library/How-is-Facebooks-React-JavaScript-library
We'll get some deeper explanations in the official docs. Thank you for your interest and patience!
| 2013-06-14T21:56:51 | 2013-06-14T21:56:51 | {} | CONTRIBUTOR |
facebook | react | 22,136,768 | 253 | zpao | I think @vjeux updated them on jsfiddle this morning
| 2013-08-05T20:00:25 | 2013-08-05T20:00:25 | {} | MEMBER |
facebook | react | 22,140,568 | 253 | sophiebits | Yup, @vjeux updated them yesterday evening, unless you're looking at different links than I am.
| 2013-08-05T20:59:05 | 2013-08-05T20:59:05 | {} | COLLABORATOR |
facebook | react | 20,532,657 | 162 | zpao | Can we be opinionated but call it something else?
| 2013-07-05T18:25:20 | 2013-07-05T18:25:20 | {} | MEMBER |
facebook | react | 20,532,718 | 162 | petehunt | @yungsters I completely disagree. Our version of onChange is definitely what people want; it should just be named such that it is different from an event people already know.
That is, we're not concerned with staying within the spec; we're concerned with staying backwards-compatible with it. If we change onChange to behave differently, we've violated user expectations of how that event behaves, and it will be hard to earn that trust back.
| 2013-07-05T18:26:45 | 2013-07-05T18:26:45 | {} | CONTRIBUTOR |
facebook | react | 20,532,599 | 162 | yungsters | @paulshen and I have had many long discussions about this.
If we truly care about the spec (and preserving utility of the knowledge and experience we think all web developers have obtained), then we should tell people to use:
``` javascript
<input type="text" onInput={...} />
<input type="checkbox" onClick={...} />
<select onChange={...}>{...}</select>
```
This would involve polyfilling `onChange` and `onInput` on all browsers (i.e. breaking apart `ChangeEventPlugin`). IMO, this API sucks but it is what the W3C spec and browsers have designed for us and what we should tell people to use if we want React to not be opinionated.
| 2013-07-05T18:23:59 | 2013-07-05T18:23:59 | {} | CONTRIBUTOR |
facebook | react | 20,532,360 | 162 | petehunt | +1
| 2013-07-05T18:18:36 | 2013-07-05T18:18:36 | {} | CONTRIBUTOR |
facebook | react | 21,313,579 | 162 | vjeux | We shipped onChange so I'm closing this task out.
| 2013-07-21T17:30:59 | 2013-07-21T17:30:59 | {
"laugh": 1
} | CONTRIBUTOR |
facebook | react | 20,214,655 | 78 | benjamn | Had an idea for this: we could generate a browserified bundle where each module dynamically creates a `<script>` tag with the module source. Then hopefully PhantomJS could give the right line numbers for individual module files.
| 2013-06-28T21:11:46 | 2013-06-28T21:11:46 | {} | CONTRIBUTOR |
facebook | react | 21,359,365 | 78 | benjamn | This was fixed by https://github.com/facebook/react/commit/c6c4657f83264525ee4f510c2417ae58a7e72a4e, although I should mention that I am still having trouble getting file names to show up in the test output.
| 2013-07-22T17:06:48 | 2013-07-22T17:06:48 | {} | CONTRIBUTOR |
facebook | react | 20,824,507 | 78 | benjamn | I'm actually going to do this.
| 2013-07-11T16:31:15 | 2013-07-11T16:31:15 | {} | CONTRIBUTOR |
facebook | react | 21,060,151 | 163 | petehunt | They're included in https://github.com/facebook/react/pull/188 as well as best practices
| 2013-07-16T17:51:04 | 2013-07-16T17:51:04 | {} | CONTRIBUTOR |
facebook | react | 21,062,020 | 163 | tomocchino | awesome!
| 2013-07-16T18:16:21 | 2013-07-16T18:16:21 | {} | CONTRIBUTOR |
facebook | react | 21,059,879 | 163 | tomocchino | Is anyone on point to migrate the docs from dex over to github? @petehunt, @yungsters?
| 2013-07-16T17:47:38 | 2013-07-16T17:47:38 | {} | CONTRIBUTOR |
facebook | react | 21,313,376 | 116 | vjeux | It's now working :) Closing
| 2013-07-21T17:17:31 | 2013-07-21T17:17:31 | {} | CONTRIBUTOR |
facebook | react | 19,841,487 | 116 | jeffmo | I can confirm this works after the empty-xjs-expressions diff (which is coming as soon as I can coordinate with @zpao on pushing separate dependent repos -- which should be in the coming day or two I hope)
| 2013-06-21T21:20:44 | 2013-06-21T21:20:44 | {} | CONTRIBUTOR |
facebook | react | 19,922,993 | 116 | zpao | FYI: You should be safe to push that to esprima at any point now. Once it's there we can pull down the updated transform and update our esprima dependency rev.
| 2013-06-24T17:43:17 | 2013-06-24T17:43:17 | {} | MEMBER |
facebook | react | 21,671,206 | 231 | zpao | @jakubmal I pushed out React (and more important react-source) v0.4.1 yesterday with you changes to JSXTransformer, so now the gem dependency can work without having to build and install react-source locally. I also just synced my branch with what's going to end up in the separate repo (https://github.com/zpao/react/tree/contrib-react-rails/contrib/react-rails). If you wanted to do any work, feel free to start doing PRs against that! I have a list of todos in the readme. The biggest thing will be tests, though if you think some other part of this is higher pri, feel free to hack on whatever. Anything will help! I'll make sure we maintain authorship into the new repo if we get changes in before the standalone repo opens up.
| 2013-07-27T19:34:47 | 2013-07-27T19:34:47 | {} | MEMBER |
facebook | react | 21,886,168 | 231 | zpao | As I mentioned in #233, we now have https://github.com/facebook/react-rails, so this is a wontfix here. Thanks again for forcing the issue @jakubmal :fireworks:
| 2013-07-31T18:51:33 | 2013-07-31T18:51:33 | {} | MEMBER |
facebook | react | 21,521,241 | 231 | zpao | Doing a little bit of cleanup, but it works!

| 2013-07-24T22:26:50 | 2013-07-24T22:26:50 | {} | MEMBER |
facebook | react | 21,516,920 | 231 | zpao | Hey @jakubmal, I'm actually working on this _right now_. Going to have a branch in my repo very shortly. Sorry if this is duplicating work, but let's converge on a single solution! I'll post here once mine is up and you can tell me it sucks and we should just use yours - I actually haven't written a proper gem (react-source doesn't count) so I'm probably doing a lot wrong!
| 2013-07-24T21:17:53 | 2013-07-24T21:17:53 | {} | MEMBER |
facebook | react | 21,516,841 | 231 | petehunt | This is freaking fantastic! Will this be rails-specific or work in any sprockets environment?
Also, once this is working I would love to port over some of Insta's internal Django integration stuff to react-rails (including transparent server rendering), if it makes sense!
| 2013-07-24T21:16:32 | 2013-07-24T21:16:32 | {} | CONTRIBUTOR |
facebook | react | 21,517,227 | 231 | jtmalinowski | Alright! I started watching your repo @zpao !
| 2013-07-24T21:22:33 | 2013-07-24T21:22:33 | {} | CONTRIBUTOR |
OpenGitHub Meta
What is it?
The full development metadata of 2 public GitHub repositories, fetched from the GitHub REST API and GraphQL API, converted to Parquet and hosted here for easy access.
Right now the archive has 1.1M rows across 8 tables in 80.8 MB of Zstd-compressed Parquet. Every issue, pull request, comment, code review, timeline event, file change, and CI status check is stored as a separate table you can load individually or query together.
This is the companion to OpenGitHub, which mirrors the real-time GitHub event stream via GH Archive. That dataset tells you what happened across all of GitHub. This one gives you the full picture for specific repos: complete issue threads, full PR review conversations, the state machine from open to close.
People use it for:
- Code review research with inline comments attached to specific diff lines
- Project health metrics like merge rates, review turnaround, label usage
- Issue triage and classification with full text, labels, and timeline
- Software engineering process mining from timeline event sequences
Last updated: 2026-03-29.
Repositories
| Repository | Issues | PRs | Comments | Reviews | Timeline | Total |
|---|---|---|---|---|---|---|
| facebook/react | 33.6K | 19.2K | 127.6K | 20.1K | 248.3K | 814.2K |
| golang/go | 75.7K | 4.9K | 0 | 323 | 107.3K | 260.0K |
How to download and use this dataset
Data lives at data/{table}/{owner}/{repo}/0.parquet. Load a single table, a single repo, or everything at once. Standard Hugging Face Parquet layout, works with DuckDB, datasets, pandas, and huggingface_hub out of the box.
Using DuckDB
DuckDB reads Parquet directly from Hugging Face, no download step needed. Save any query below as a .sql file and run it with duckdb < query.sql.
-- Top issue authors across all repos
SELECT
author,
COUNT(*) as issue_count,
COUNT(*) FILTER (WHERE state = 'open') as open,
COUNT(*) FILTER (WHERE state = 'closed') as closed
FROM read_parquet('hf://datasets/open-index/open-github-meta/data/issues/**/0.parquet')
WHERE is_pull_request = false
GROUP BY author
ORDER BY issue_count DESC
LIMIT 20;
-- PR merge rate by repo
SELECT
split_part(filename, '/', 8) || '/' || split_part(filename, '/', 9) as repo,
COUNT(*) as total_prs,
COUNT(*) FILTER (WHERE merged) as merged,
ROUND(COUNT(*) FILTER (WHERE merged) * 100.0 / COUNT(*), 1) as merge_pct
FROM read_parquet('hf://datasets/open-index/open-github-meta/data/pull_requests/**/0.parquet', filename=true)
GROUP BY repo
ORDER BY total_prs DESC;
-- Most reviewed PRs by number of review submissions
SELECT
r.pr_number,
COUNT(*) as review_count,
COUNT(*) FILTER (WHERE r.state = 'APPROVED') as approvals,
COUNT(*) FILTER (WHERE r.state = 'CHANGES_REQUESTED') as changes_requested
FROM read_parquet('hf://datasets/open-index/open-github-meta/data/reviews/**/0.parquet') r
GROUP BY r.pr_number
ORDER BY review_count DESC
LIMIT 20;
-- Label activity over time (monthly)
SELECT
date_trunc('month', created_at) as month,
COUNT(*) as label_events
FROM read_parquet('hf://datasets/open-index/open-github-meta/data/timeline_events/**/0.parquet')
WHERE event_type = 'LabeledEvent'
GROUP BY month
ORDER BY month;
-- Largest PRs by lines changed
SELECT
number,
additions,
deletions,
changed_files,
additions + deletions as total_lines
FROM read_parquet('hf://datasets/open-index/open-github-meta/data/pull_requests/**/0.parquet')
ORDER BY total_lines DESC
LIMIT 20;
Using Python (uv run)
These scripts use PEP 723 inline metadata. Save as a .py file and run with uv run script.py. No virtualenv or pip install needed.
Stream issues:
# /// script
# requires-python = ">=3.11"
# dependencies = ["datasets"]
# ///
from datasets import load_dataset
ds = load_dataset("open-index/open-github-meta", "issues", streaming=True)
for i, row in enumerate(ds["train"]):
print(f"#{row['number']}: [{row['state']}] {row['title']} (by {row['author']})")
if i >= 19:
break
Load a specific repo:
# /// script
# requires-python = ">=3.11"
# dependencies = ["datasets"]
# ///
from datasets import load_dataset
ds = load_dataset(
"open-index/open-github-meta",
"pull_requests",
data_files="data/pull_requests/facebook/react/0.parquet",
)
df = ds["train"].to_pandas()
print(f"Loaded {len(df)} pull requests")
print(f"Merged: {df['merged'].sum()} ({df['merged'].mean()*100:.1f}%)")
print(f"\nTop 10 by lines changed:")
df["total_lines"] = df["additions"] + df["deletions"]
print(df.nlargest(10, "total_lines")[["number", "additions", "deletions", "total_lines"]].to_string(index=False))
Download files:
# /// script
# requires-python = ">=3.11"
# dependencies = ["huggingface-hub"]
# ///
from huggingface_hub import snapshot_download
# Download only issues
snapshot_download(
"open-index/open-github-meta",
repo_type="dataset",
local_dir="./open-github-meta/",
allow_patterns="data/issues/**/*.parquet",
)
print("Downloaded issues parquet files to ./open-github-meta/")
For faster downloads, install pip install huggingface_hub[hf_transfer] and set HF_HUB_ENABLE_HF_TRANSFER=1.
Dataset structure
issues
Both issues and PRs live in this table (check is_pull_request). Join with pull_requests on number for PR-specific fields like merge status and diff stats.
| Column | Type | Description |
|---|---|---|
number |
int32 | Issue/PR number (primary key) |
node_id |
string | GitHub GraphQL node ID |
is_pull_request |
bool | True if this is a PR |
title |
string | Title |
body |
string | Full body text in Markdown |
state |
string | open or closed |
state_reason |
string | completed, not_planned, or reopened |
author |
string | Username of the creator |
created_at |
timestamp | When opened |
updated_at |
timestamp | Last activity |
closed_at |
timestamp | When closed (null if open) |
labels |
string (JSON) | Array of label names |
assignees |
string (JSON) | Array of assignee usernames |
milestone_title |
string | Milestone name |
milestone_number |
int32 | Milestone number |
reactions |
string (JSON) | Reaction counts ({"+1": 5, "heart": 2}) |
comment_count |
int32 | Number of comments |
locked |
bool | Whether the conversation is locked |
lock_reason |
string | Lock reason |
pull_requests
PR-specific fields. Join with issues on number for title, body, labels, and other shared fields.
| Column | Type | Description |
|---|---|---|
number |
int32 | PR number (matches issues.number) |
merged |
bool | Whether the PR was merged |
merged_at |
timestamp | When merged |
merged_by |
string | Username who merged |
merge_commit_sha |
string | Merge commit SHA |
base_ref |
string | Target branch (e.g. main) |
head_ref |
string | Source branch |
head_sha |
string | Head commit SHA |
additions |
int32 | Lines added |
deletions |
int32 | Lines deleted |
changed_files |
int32 | Number of files changed |
draft |
bool | Whether the PR is a draft |
maintainer_can_modify |
bool | Whether maintainers can push to the head branch |
comments
Conversation comments on issues and PRs. These are the threaded discussion comments, not inline code review comments (those are in review_comments).
| Column | Type | Description |
|---|---|---|
id |
int64 | Comment ID (primary key) |
issue_number |
int32 | Parent issue/PR number |
author |
string | Username |
body |
string | Comment body in Markdown |
created_at |
timestamp | When posted |
updated_at |
timestamp | Last edit |
reactions |
string (JSON) | Reaction counts |
author_association |
string | OWNER, MEMBER, CONTRIBUTOR, NONE, etc. |
review_comments
Inline code review comments on PR diffs. Each comment is attached to a specific file and line in the diff.
| Column | Type | Description |
|---|---|---|
id |
int64 | Comment ID (primary key) |
pr_number |
int32 | Parent PR number |
review_id |
int64 | Parent review ID |
author |
string | Reviewer username |
body |
string | Comment body in Markdown |
path |
string | File path in the diff |
line |
int32 | Line number |
side |
string | LEFT (old code) or RIGHT (new code) |
diff_hunk |
string | Surrounding diff context |
created_at |
timestamp | When posted |
updated_at |
timestamp | Last edit |
in_reply_to_id |
int64 | Parent comment ID (for threaded replies) |
reviews
PR review decisions. One row per review action on a PR.
| Column | Type | Description |
|---|---|---|
id |
int64 | Review ID (primary key) |
pr_number |
int32 | Parent PR number |
author |
string | Reviewer username |
state |
string | APPROVED, CHANGES_REQUESTED, COMMENTED, DISMISSED |
body |
string | Review summary in Markdown |
submitted_at |
timestamp | When submitted |
commit_id |
string | Commit SHA that was reviewed |
timeline_events
The full lifecycle of every issue and PR. Every label change, assignment, cross-reference, merge, force-push, lock, and other state transition.
| Column | Type | Description |
|---|---|---|
id |
string | Event ID (node_id or synthesized) |
issue_number |
int32 | Parent issue/PR number |
event_type |
string | Event type (see below) |
actor |
string | Username who triggered the event |
created_at |
timestamp | When it happened |
database_id |
int64 | GitHub database ID for the event |
label_name |
string | Label name (labeled, unlabeled) |
label_color |
string | Label hex color |
state_reason |
string | Close reason: COMPLETED, NOT_PLANNED (closed) |
assignee_login |
string | Username assigned/unassigned (assigned, unassigned) |
milestone_title |
string | Milestone name (milestoned, demilestoned) |
title_from |
string | Previous title before rename (renamed) |
title_to |
string | New title after rename (renamed) |
ref_type |
string | Referenced item type: Issue or PullRequest (cross-referenced, referenced) |
ref_number |
int32 | Referenced issue/PR number |
ref_url |
string | URL of the referenced item |
will_close |
bool | Whether the reference will close this issue |
lock_reason |
string | Lock reason (locked) |
data |
string (JSON) | Remaining event-specific payload (common fields stripped) |
Event types: labeled, unlabeled, closed, reopened, assigned, unassigned, milestoned, demilestoned, renamed, cross-referenced, referenced, locked, unlocked, pinned, merged, review_requested, head_ref_force_pushed, head_ref_deleted, ready_for_review, convert_to_draft, and more.
Common fields (actor, created_at, database_id and extracted columns above) are stored in dedicated columns and removed from data to reduce storage. The data field contains only remaining event-specific payload. See the GitHub GraphQL timeline items documentation for the full type catalog.
pr_files
Every file touched by each pull request, with per-file diff statistics.
| Column | Type | Description |
|---|---|---|
pr_number |
int32 | Parent PR number |
path |
string | File path |
additions |
int32 | Lines added |
deletions |
int32 | Lines deleted |
status |
string | added, removed, modified, renamed |
previous_filename |
string | Original path (for renames) |
commit_statuses
CI/CD status checks and GitHub Actions results for each commit.
| Column | Type | Description |
|---|---|---|
sha |
string | Commit SHA |
context |
string | Check name (e.g. ci/circleci, check:build) |
state |
string | success, failure, pending, error |
description |
string | Status description |
target_url |
string | Link to CI details |
created_at |
timestamp | When reported |
Dataset statistics
| Table | Rows | Description |
|---|---|---|
issues |
109.4K | Issues and pull requests (shared metadata) |
pull_requests |
24.1K | PR-specific fields (merge status, diffs, refs) |
comments |
104.6K | Conversation comments on issues and PRs |
review_comments |
23.1K | Inline code review comments on PR diffs |
reviews |
20.4K | PR review decisions |
timeline_events |
355.6K | Activity timeline (labels, closes, merges, assignments) |
pr_files |
273.1K | Files changed in each pull request |
commit_statuses |
164.0K | CI/CD status checks per commit |
| Total | 1.1M |
How it's built
The sync pipeline uses both GitHub APIs. The REST API handles bulk listing: issues, comments, and review comments are fetched repo-wide with since-based incremental pagination and parallel page fetching across multiple tokens. The GraphQL API handles per-item detail: one query grabs reviews, timeline events, file changes, and commit statuses in a single round trip, with automatic REST fallback for PRs with more than 100 files or reviews.
Multiple GitHub Personal Access Tokens rotate round-robin to spread rate limit load. The pipeline is fully incremental and idempotent: re-running picks up only what changed since the last sync.
Everything lands in per-repo DuckDB files first, then gets exported to Parquet with Zstd compression for publishing here. No filtering, deduplication, or content changes. Bot activity, automated PRs, CI noise, Dependabot upgrades, all of it is preserved, because that's how repos actually work.
Known limitations
- Point-in-time snapshot. Data reflects the state at the last sync, not real-time. Incremental updates capture everything that changed since the previous sync.
- Bot activity included. Comments and PRs from bots (Dependabot, Renovate, GitHub Actions, etc.) are included without filtering. This is intentional. Filter on
authorif you want humans only. - JSON columns.
labels,assignees,reactions, anddatacontain JSON strings. Usejson_extract()in DuckDB orjson.loads()in Python. - Body text can be large. Issue and comment bodies contain full Markdown, sometimes with embedded images. Project only the columns you need for memory-constrained workloads.
- Timeline data varies by event type. The
datafield intimeline_eventscontains the raw event payload as JSON. The schema depends onevent_type.
Personal and sensitive information
Usernames, user IDs, and author associations are included as they appear in the GitHub API. All data was already publicly accessible on GitHub. Email addresses do not appear in this dataset (they exist only in git commit objects, which are in the separate code archive, not here). No private repository data is present.
License
Released under the Open Data Commons Attribution License (ODC-By) v1.0. The underlying data is sourced from GitHub's public API. GitHub's Terms of Service apply to the original data.
Thanks
All the data here comes from GitHub's public REST API and GraphQL API. We are grateful to the open-source maintainers and contributors whose work is represented in these tables.
- OpenGitHub, our companion dataset covering the full GitHub event stream via GH Archive by Ilya Grigorik
- Built with DuckDB (Go driver), Apache Parquet (Zstd compression), published via Hugging Face Hub
Questions, feedback, or issues? Open a discussion on the Community tab.
- Downloads last month
- 63